Refactor and Code Cleanup - Githubissues

ttakahashi1591 / viewing_party_lite

0 stars 1 forks source link

Refactor and Code Cleanup #23

Closed Sykogst closed 11 months ago

Sykogst commented 11 months ago

Description

This PR will contain miscellaneous refactors and code cleanup

ViewingParty Controller

Renamed #create_parties to #create_user_parties,
Rename key/value element for readability
Remove handrolled route for create action

Movie Poro

Test for image path instance variable
private method block: now contains #actor_details and #review_details (I think this is encapsulation)
Update spec tests to call instance variables to ensure the methods work
Add test for @image instance

Type of Change

[ ] fix
[ ] feat
[ ] test
[x] refactor
[ ] docs

Checklist

[x] Code has been self reviewed
[x] Code runs without any errors
[x] Thorough testing has been implemented if adding feature
[x] All tests pass