search

ttalvitie / browservice

Browservice: Browse the modern web on historical browsers
MIT License
1.08k stars 32 forks source link

Unhandled Exception #98

Open HEB2021 opened 1 year ago

HEB2021 commented 1 year ago

WARNING @ retrojsvice.dll C:\build\src\viceplugins\retrojsvice\src\http.cpp:76 -- HTTP response not provided, sending internal server error PANIC @ retrojsvice.dll C:\build\src\viceplugins\retrojsvice\src\vice_plugin_api.cpp:198: Unhandled exception traversing the vice plugin API: regex_error(error_stack): There was insufficient memory to determine whether the regular expression could match the specified character sequence. [0418/031602.252:FATAL:common.cpp(109)]

This was the last message the server said before it crashed. The client was IE6 on Win2000 over a 24Kbps Dial up connection I know I cant expect it to be fast over dial up but im very patient. Hopefully this helps you figure something out txt me if you need more info

ttalvitie commented 1 year ago

Thank you for the report, and sorry for the late reply. I believe this error is caused by the bad regex implementation in the MSVC C++ standard library combined with the long URLs we get in cases where there is a lot of input events (mouse move/key press) and a very slow connection. I will eventually fix this by reimplementing the URL parsing without regexes or limiting the URL length in the JavaScript code (or both), but it's not a top priority as it shouldn't break browsing with normal usable speeds.

HEB2021 commented 1 year ago

All good theres no rush for such an edge case exception such as one caused by slow speeds. I have major respect for what youre creating here its made using older devices a lot easier. :))