feat!: make sinon a peer dependency

ttarnowski / ts-sinon

Sinon extension providing functions to: stub all object methods and to stub interface.

MIT License

69 stars 15 forks source link

feat!: make sinon a peer dependency #255

Open ahippler opened 2 years ago

ahippler commented 2 years ago

BREAKING CHANGE: sinon and @types/sinon have to be installed along with ts-sinon to pevent issues because of different sinon versions

achingbrain commented 2 years ago

This would be very helpful to have, ts-sinon's version of sinon is now very old and incompatibilities creep in with newer versions - custom argument matchers don't work for example.

@ttarnowski any chance of this getting merged and released?

achingbrain commented 2 years ago

@ahippler I've forked this module, updated it to ESM and released it as sinon-ts - it has sinon as a peer dep so you may find it useful.

I'll likely retire it if this gets fixed.