Custom Sizes Attribute is missing in Output

ttc-freebies / plugin-responsive-images

Responsive images for Joomla! articles (com_content)

https://responsive-images.dgrammatiko.dev

GNU General Public License v2.0

87 stars 9 forks source link

Custom Sizes Attribute is missing in Output #568

Open Der-Lizzard opened 8 months ago

Der-Lizzard commented 8 months ago

Joomla 4.3.3 and PHP 8.1

Tested with plugin versions 4.2.6 and the latest 4.2.7.

In Frontend, the custom sizes attribute is missing.

If you remove the commented out array_push in line 248 (file: \libraries\Ttc\src\Freebies\Responsive\Helper.php), the custom sizes attribute is shown in frontend.

With commented out without

Removed commented out with

dgrammatiko commented 8 months ago

Pls are welcome, although:

the sizes would be nice to be user driven (or derived from the breakpoints, the commented code is hardcoded to the default values)
the sizes are optional (https://developer.mozilla.org/en-US/docs/Learn/HTML/Multimedia_and_embedding/Responsive_images)

Der-Lizzard commented 8 months ago

Yes, i know - the sizes are optional - but if there is a field for sizes in the plugin-config, i thought i can use it ;-)

dgrammatiko commented 8 months ago

Turns out that I never implemented that feature, the field exists but it's not really used. I will try to publish an update when I get some free time.

Thanks