search

ttcdt / mp-5.x

The Minimum Profit Text Editor
The Unlicense
23 stars 4 forks source link

Config 3 #13

Closed rofl0r closed 3 years ago

rofl0r commented 3 years ago

same as #9, however without the bug i introduced there (see last commit). i overlooked that the last compiler check wasn't actually just compiling a testcase, but also adding a custom .o file to the command line. i restored that part of the file to its original contents.

X-Ryl669 commented 3 years ago

Tried and it works for me. Thanks.

rofl0r commented 3 years ago

hello tiny, no need to be afraid of this PR. the issue i overlooked in the last one is fixed. the PR makes ncurses/netbsd-curses detection work finally on all platforms and brings other improvements: all compile tests go through a single function, so finally the config.log has complete coverage of all tests that were run. also compile checks for e.g. QT and KDE are no longer being run when there's no pkgconfig file which would provide the proper CFLAGS, which in the past just caused the compile to run anyway without any chance of succeeding, slowing down the configure process.

ttcdt commented 3 years ago

looks fine. been busy, just applied PR

thanks