search

ttcdt / mp-5.x

The Minimum Profit Text Editor
The Unlicense
23 stars 4 forks source link

improve config.sh, fix ncurses detection #9

Closed rofl0r closed 3 years ago

rofl0r commented 3 years ago

(tested with dash, the most restrictive/posixly_correct shell)

rofl0r commented 3 years ago

just ftr, the ncurses detection before this commit was broken when using netbsd-curses, also the transparency and wget_wch checks could never complete successfully because the required C/LDFLAGS for ncurses were not used for those checks.

rofl0r commented 3 years ago

@X-Ryl669 : would you mind testing this and provide your feedback? thanks!

ttcdt commented 3 years ago

This patch breaks everything and generates a non-working mp:

tiny@hell:~/src/mp-5.x$ ./mp-5 mp_core.mpsl: file not found

Didn't investigate further but from the make output I see it's generating mp.tar but expecting mp.zip.

11/11/20 14:40, rofl0r:

    You can view, comment on, or merge this pull request online at:

  https://github.com/ttcdt/mp-5.x/pull/9 https://github.com/ttcdt/mp-5.x/pull/9

    Commit Summary

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ttcdt/mp-5.x/pull/9, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP4PJ2PQYY3Z6Y2VR2RUYSDSPKH3DANCNFSM4TSADFOQ.