search

ttdung11t2 / react-native-confirmation-code-input

A react-native component to input confirmation code for both Android and IOS
MIT License
411 stars 349 forks source link

Backspace is not working in Android #1

Closed ksshanu closed 6 years ago

ksshanu commented 6 years ago

Hi,

Android backspace button is not working as expected in this module.

ttdung11t2 commented 6 years ago

Yes, on Android, InputText doesn't fire onKeyPress event, so backspace button is not working. you can tap on the letter/number to remove it

raduflp commented 6 years ago

hopefully that will change after this is merged.

ttdung11t2 commented 6 years ago

Yes, If the backspace event is working on Android, it will work as the same in IOS

joshjhargreaves commented 6 years ago

@ttdung11t2 @raduflp, would you mind testing https://github.com/facebook/react-native/pull/14720 to see if it works as you'd expect it to?

joshjhargreaves commented 6 years ago

It might be worth keeping open until this lands in react native!

ttdung11t2 commented 6 years ago

yes, should keep it open

KalebPortillo commented 6 years ago

Any news on this issue?

joshjhargreaves commented 6 years ago

I implemented onKeyPress with backspace detection in this commit: https://github.com/facebook/react-native/commit/c9ff0bc212b680232f7379fba7b9332927075c3c. It'll be released as part of react-native 0.53

edit: It'd be useful if anybody would be willing to test with the latest RC of react-native: https://github.com/facebook/react-native/tree/v0.53.0-rc.0 :).

KalebPortillo commented 6 years ago

I will test and let you guys know

KalebPortillo commented 6 years ago

It worked on 0.53.0-rc.0, both Android and IOS Thanks @joshyhargreaves

hungdev commented 6 years ago

thanks @joshyhargreaves . it worked on 0.53.0