tteck / Proxmox

Proxmox VE Helper-Scripts
https://Helper-Scripts.com
MIT License
11.68k stars 1.81k forks source link

Add new LXC: MeTube #3179

Closed MickLesk closed 2 weeks ago

MickLesk commented 2 weeks ago

I wanted to make you aware that I am meticulous when it comes to merging code into the main branch, so please don't take it personally if I reject your request.

Description

New MeTube LXC added

Special note:

Port: 8081 Disk space: 10 GB by default (otherwise it fills up too quickly with YouTube downloads :D) Source: https://github.com/alexta69/metube

A short code review would be nice. So far everything works, I have removed unnecessary packages and updated NodeJS to the latest dearmor gpg version.

Request: https://github.com/tteck/Proxmox/discussions/50#discussioncomment-9745632

image

Fixes # (issue)

Type of change

Please delete options that are not relevant.

ponchohoncho commented 1 week ago

How can we set environment variables in this container? Typically we'd have docker envs, or a conf or json to edit, but I can't find clear guidance for how to set the metube configuration using the environment variables it uses.

MickLesk commented 1 week ago

nano /opt/metube/.env

ponchohoncho commented 1 week ago

Ah, thank you! Finding that file solved the issue I was trying to fix. The downloaded files had very short names and I was trying to change the format. I found in your .env that YTDL_OPTIONS had been set with a trim_file_name option set to limit file names to 10 characters. I edited that on my end, but it seems like an odd default. It led to a lot of confusion and clobbered (well, specifically not-clobbered as it wouldn't overwrite what was already there) downloads of videos with similar filenames.