Angle code is probably wrong

tteepe / GaitGraph

Official repository for "GaitGraph: Graph Convolutional Network for Skeleton-Based Gait Recognition" (ICIP'21)

https://arxiv.org/abs/2101.11228

MIT License

91 stars 27 forks source link

Closed HiAleeYang closed 2 years ago

HiAleeYang commented 2 years ago

https://github.com/tteepe/GaitGraph/blob/030163b8392cd0c748bdacf084831a8590de041e/src/datasets/augmentation.py#L43 you use a loop, but the data_new[2, C, :, :] just gets the last value after the loop. According to the distribution of the Multiple Input Branches in the paper('ResGCN'), it's allowed to calculate i th angle of bone by i th bone length

tteepe commented 2 years ago

Yes good find! It is not used in this repo for the reported results. It was corrected in GaitGraph2.