Transcription fixes / features

ttempe / chinese-support-addon

Addon for Anki2 that makes easier to input Chinese, in the spirit of batterseapower’s pinyin-toolkit for Anki1

https://github.com/ttempe/chinese-support-addon/wiki

47 stars 19 forks source link

Transcription fixes / features #38

Closed jkitching closed 10 years ago

jkitching commented 10 years ago

Enable proper transcription for Taiwanese Pinyin; (wasn't checking for "Taiwan (Pinyin)" config value)
add support for changing tones by appending a tone number after a syllable; (added to regex)
strip Anki's tag which messes up transcription. (example: nǐ hǎo, put the cursor after the space, hit backspace, then type "4")

ttempe commented 10 years ago

Great thanks! I really appreciate that you took the time to go through the code and fixed things! I'll publish these improvements in version 0.9.2, within the next 2 weeks.

jkitching commented 10 years ago

Hi ttempe, thanks for merging =) I have actually since discovered there are still a few strange bugs, and also some... let's say undefined behaviour in certain cases that should be fixed. I'll work on these and put up another pull request if that works for you!