ttencate / jfxr

A browser-based tool to create sound effects for games.
http://jfxr.frozenfractal.com/
429 stars 45 forks source link

Load from link is broken #36

Closed blurymind closed 5 years ago

blurymind commented 5 years ago

example: https://jfxr.frozenfractal.com/#%7B%22_version%22%3A1%2C%22_name%22%3A%22Hit%2Fhurt%202%22%2C%22_locked%22%3A%5B%5D%2C%22sampleRate%22%3A44100%2C%22attack%22%3A0%2C%22sustain%22%3A0.05%2C%22sustainPunch%22%3A0%2C%22decay%22%3A0.07%2C%22tremoloDepth%22%3A0%2C%22tremoloFrequency%22%3A10%2C%22frequency%22%3A600%2C%22frequencySweep%22%3A-700%2C%22frequencyDeltaSweep%22%3A-800%2C%22repeatFrequency%22%3A0%2C%22frequencyJump1Onset%22%3A33%2C%22frequencyJump1Amount%22%3A0%2C%22frequencyJump2Onset%22%3A66%2C%22frequencyJump2Amount%22%3A0%2C%22harmonics%22%3A0%2C%22harmonicsFalloff%22%3A0.5%2C%22waveform%22%3A%22square%22%2C%22interpolateNoise%22%3Atrue%2C%22vibratoDepth%22%3A0%2C%22vibratoFrequency%22%3A10%2C%22squareDuty%22%3A50%2C%22squareDutySweep%22%3A0%2C%22flangerOffset%22%3A5%2C%22flangerOffsetSweep%22%3A2%2C%22bitCrush%22%3A16%2C%22bitCrushSweep%22%3A0%2C%22lowPassCutoff%22%3A22050%2C%22lowPassCutoffSweep%22%3A-4100%2C%22highPassCutoff%22%3A0%2C%22highPassCutoffSweep%22%3A0%2C%22compression%22%3A1%2C%22normalization%22%3Atrue%2C%22amplification%22%3A100%7D

To reproduce:

  1. open https://jfxr.frozenfractal.com
  2. create a link to the current sound and copy it
  3. open the link in another tab

tested with: chrome, opera, electron

blurymind commented 5 years ago

Thank you :) I might use this for how data is stored and loaded by gdevelop, as it is more compressed than storing the entire sound object- which is how i have it implemented atm

On Wed, 24 Oct 2018 08:31 Thomas ten Cate, notifications@github.com wrote:

Closed #36 https://github.com/ttencate/jfxr/issues/36 via 5b5cec6 https://github.com/ttencate/jfxr/commit/5b5cec6ec5df417e1eaad9ae1ca8c680906d7560 .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ttencate/jfxr/issues/36#event-1922567699, or mute the thread https://github.com/notifications/unsubscribe-auth/AGMbVQQUfLxC-oT4NxpmbWivCXIdSCIxks5uoBdNgaJpZM4X2F72 .

blurymind commented 5 years ago

Btw this might solve https://github.com/ttencate/jfxr/issues/37 for me, if it autoplays the sound from the url #string