Tremolo applied twice. - Githubissues

ttencate / jfxr

A browser-based tool to create sound effects for games.

http://jfxr.frozenfractal.com/

429 stars 45 forks source link

Tremolo applied twice. #40

Closed jyaif closed 5 years ago

jyaif commented 5 years ago

I'm not 100% sure as I only looked at the code, but I believe Tremolo is applied twice to the sound:

once in the "Envelope" phase via the amplitudeAt function.
once in the "Tremolo" phase.

ttencate commented 5 years ago

Why yes, you're absolutely right. You can see the difference if you set the attack, sustain punch and decay all to 0, which bypasses the Envelope transformer:

without Attack (correct, single tremolo)
with Attack (double tremolo)

ttencate commented 5 years ago

The fix is now live. Due to broken caching header configuration on my server (now also fixed) you may need a hard refresh.

jyaif commented 5 years ago

Amazing. Thank you very much.