ttencate / jfxr

A browser-based tool to create sound effects for games.
http://jfxr.frozenfractal.com/
432 stars 45 forks source link

Something horribly wrong with encoding in links #8

Closed ttencate closed 10 years ago

ttencate commented 10 years ago

From http://www.reddit.com/r/gamedev/comments/2ci8mo/announcing_jfxr_a_tool_to_quickly_make_sound/cjfxn8k: http://jfxr.frozenfractal.com/#%7B%22_version%22:1,%22_name%22:%22Jump%20Sound%22,%22_locked%22:%5B%5D,%22sampleRate%22:44100,%22attack%22:0.03,%22sustain%22:0.2,%22sustainPunch%22:0,%22decay%22:0.12,%22tremoloDepth%22:0,%22tremoloFrequency%22:10,%22frequency%22:500,%22frequencySweep%22:50,%22frequencyDeltaSweep%22:0,%22repeatFrequency%22:0,%22frequencyJump1Onset%22:33,%22frequencyJump1Amount%22:0,%22frequencyJump2Onset%22:66,%22frequencyJump2Amount%22:0,%22harmonics%22:0,%22harmonicsFalloff%22:0.5,%22waveform%22:%22sine%22,%22interpolateNoise%22:true,%22vibratoDepth%22:0,%22vibratoFrequency%22:10,%22squareDuty%22:50,%22squareDutySweep%22:0,%22flangerOffset%22:0,%22flangerOffsetSweep%22:0,%22bitCrush%22:16,%22bitCrushSweep%22:0,%22lowPassCutoff%22:22050,%22lowPassCutoffSweep%22:0,%22highPassCutoff%22:0,%22highPassCutoffSweep%22:0,%22compression%22:1,%22normalization%22:true,%22amplification%22:100%7D does not work. We should probably percent-encode the generated URL to begin with, and accept percent-encoded URLs upon receiving.