search

tterb / gatsby-plugin-disqus

:speech_balloon: A plugin for adding Disqus comments to GatsbyJS
https://brettstevenson.io/gatsby-plugin-disqus
MIT License
45 stars 5 forks source link

Please update dependency of React to 17.x #47

Closed productiveme closed 3 years ago

productiveme commented 3 years ago

Is your feature request related to a problem? Please describe. Cannot install due to conflicts with Gatsby React version

Describe the solution you'd like Package.json updated for support of latest React

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context

npm install -S gatsby-plugin-disqus
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! Found: react@17.0.2
npm ERR! node_modules/react
npm ERR!   peer react@">=16.8.0" from @emotion/react@11.4.0
npm ERR!   node_modules/@emotion/react
npm ERR!     peer @emotion/react@"^11.0.0-rc.0" from @emotion/styled@11.3.0
npm ERR!     node_modules/@emotion/styled
npm ERR!       @emotion/styled@"^x" from the root project
npm ERR!     peer @emotion/react@"^11.0.0" from gatsby-plugin-emotion@6.9.0
npm ERR!     node_modules/gatsby-plugin-emotion
npm ERR!       gatsby-plugin-emotion@"^x" from the root project
npm ERR!     1 more (the root project)
npm ERR!   peer react@">=16.8.0" from @emotion/styled@11.3.0
npm ERR!   node_modules/@emotion/styled
npm ERR!     @emotion/styled@"^x" from the root project
npm ERR!   11 more (@gatsbyjs/reach-router, gatsby, gatsby-link, ...)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! gatsby-plugin-disqus@"*" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: react@16.14.0
npm ERR! node_modules/react
npm ERR!   peer react@"^16.8.5" from gatsby-plugin-disqus@1.2.2
npm ERR!   node_modules/gatsby-plugin-disqus
npm ERR!     gatsby-plugin-disqus@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
productiveme commented 3 years ago

Made a PR here https://github.com/tterb/gatsby-plugin-disqus/pull/48