search

tterrag1098 / BON2

A rewrite for Immibis's bearded-octo-nemesis for ForgeGradle
GNU Lesser General Public License v3.0
182 stars 50 forks source link

Fix NPE when manifest doesn't exist #5

Closed clienthax closed 9 years ago

Parker8283 commented 9 years ago

This is two things. Pick one or the other. Also, have you tested the fix with mods like IC2? Because I'm pretty sure that this fix doesn't fix it If I'm remembering the error correctly.

clienthax commented 9 years ago

Ic2 works fine

Parker8283 commented 9 years ago

Hmm...so the manifest is null if the JAR is signed? That seems weird...

IC2 has a manifest. It must. It has a coremod.

I only ever ran into this problem with mods that signed their jars. All other mods worked fine.

clienthax commented 9 years ago

i tried it with mocreatures and it expected a meta-inf to be there, which was missing.

clienthax commented 9 years ago

i also tryed with a ic2-experimental (signed) that dmod sent me after this change and it worked fine (moved the meta-inf over too)

Parker8283 commented 9 years ago

DId it have the FMLCorePlugin attributes in the manifest?

clienthax commented 9 years ago

yes, Manifest-Version: 1.0 FMLCorePlugin: ic2.core.coremod.IC2core FMLCorePluginContainsFMLMod: true and then the class signatures (which are wrong)

On 11 December 2014 at 13:58, Parker Young notifications@github.com wrote:

DId it have the FMLCorePlugin attributes in the manifest?

— Reply to this email directly or view it on GitHub https://github.com/Parker8283/BON2/pull/5#issuecomment-66621876.

clienthax commented 9 years ago

seems to relate to http://bugs.java.com/view_bug.do?bug_id=4338238 ?

clienthax commented 9 years ago

made a workaround, what do you think?

Parker8283 commented 9 years ago

I'm going to have to do some testing myself on this before this gets pulled.