tterrag1098 / Blur

Modifies the background behind Minecraft GUIs to have a blur effect
MIT License
41 stars 49 forks source link

No blur effect with better portals #38

Open jhammerberg opened 4 years ago

jhammerberg commented 4 years ago

The mod simply doesn't blur when the better portals mod is installed, instead it just dims.

tterrag1098 commented 4 years ago

Have you reported this to them? Usually it means they are forcing the current shader to their own.

Johni0702 commented 4 years ago

If this happens even when no portals exist, then the only thing I can think of which BP changes wrt vanilla shaders is fixing a bug in their blend state handling: https://github.com/Johni0702/BetterPortals/issues/229 This should only cause issues if Blur is accidentally relying on the broken behavior.

Only other thing I can think of is that BP copies the vanilla frame buffer to a temporary one and back (for reasons which make more sense when there's portals, but it does it either way) at the end of the EntityRenderer.renderWorld call in EntityRenderer.updateCameraAndRender. Don't see how that would cause this issue though.

tterrag1098 commented 4 years ago

I see, it could be the same blend issue as described above. @Warp8 what version of Minecraft are you using, so I can get you a test version?

jhammerberg commented 4 years ago

I'm using Minecraft version 1.12.2 with Forge 14.23.5.2847

jhammerberg commented 4 years ago

Is there any update on this?