search

tterrag1098 / Registrate

Your mod's best friend - keep your registry objects simple and organized
Mozilla Public License 2.0
114 stars 32 forks source link

Include the provided Material in the BlockBuilder #16

Closed dliberalesso closed 4 years ago

dliberalesso commented 4 years ago

Instead of always using Material.ROCK, block() now passes along the provided material.

I also reordered the parameters for consistency.

tterrag1098 commented 4 years ago

While I'm okay with breaking changes at this point, I'm not sure this one is justified. What makes that order of parameters more consistent than the others? The entity methods also have a parameter after the factory.

dliberalesso commented 4 years ago

It is just that all the block methods that take a Material as a parameter, take it before the factory. Except the last one.

We need to change something, or Material is always the last one, or the factory.

I didn't notice the entity methods...

tterrag1098 commented 4 years ago

I see. That makes sense. We'll stick with the order most of the methods already use then.