search

tterrag1098 / Registrate

Your mod's best friend - keep your registry objects simple and organized
Mozilla Public License 2.0
114 stars 32 forks source link

Registrate does not work in a project using official mappings (MojMaps) #28

Closed TheOnlyTails closed 3 years ago

TheOnlyTails commented 3 years ago

I have a project that uses official mappings, and after I was done converting all my items and blocks over to the Registrate system, it causes Forge to throw an extremely long StackOverflowException, like in the following log.

From talking to nikita488 on your server, I understand this issue can be resolved by simply switching Registrate over to use the official mappings (at least for 1.16).

I understand this would cause problems with MCP projects, but I would argue that it's fine since Forge now considers official mappings the preferred ones.

noobanidus commented 3 years ago

This is invalid, there are other solutions than just converting to mojmap, which has its own issues. See #29

tterrag1098 commented 3 years ago

Fixed