search

tterrag1098 / Registrate

Your mod's best friend - keep your registry objects simple and organized
Mozilla Public License 2.0
117 stars 33 forks source link

Faulty FluidBuilder Source Check #32

Closed PepperCode1 closed 3 years ago

PepperCode1 commented 3 years ago

After updating Registrate from 1.0.4 to 1.0.5, the mod that was using it failed to start. The issue is that the FluidBuilder.bucket(factory) method can't be called if the .source method wasn't called, so it fails if it uses the default source but not the default bucket. This check was added in 1.0.5.

Additionally, the non-default bucket was used to make it have a max stack size of one. I think making this part of the default bucket creation could be a good idea.

tterrag1098 commented 3 years ago

Fixed via 013f4658f5848089805291737c37d63fa35d8574