search

tterrag1098 / Registrate

Your mod's best friend - keep your registry objects simple and organized
Mozilla Public License 2.0
117 stars 33 forks source link

Fix Fluids #55

Closed Rover656 closed 6 days ago

Rover656 commented 1 year ago

This PR addresses a handful of concerns with the original implementation.

  1. Fixed FluidEntry<>#getBlock -> This would always would query for modname:flowing_fluid_name instead of modname:fluid_name. Fixed this by making the FluidBuilder create both the source and flowing (and swapped the order) without any extra builder calls.
  2. Fixes fluid render types - applied the same fix as for blocks etc., it just needed to have another supplier around it to fix server-side support.
  3. More sensible fluid properties - we unset the bucket and block suppliers now if noBucket/noBlock is called

This could be considered breaking as the API has shifted slightly, so might want to bump major version :)