tterrag1098 / Registrate

Your mod's best friend - keep your registry objects simple and organized
Mozilla Public License 2.0
117 stars 33 forks source link

[1.20.1] noBucket() method is not compatible with multiple mods #69

Open cech12 opened 2 months ago

cech12 commented 2 months ago

Hello,

I am the developer of the BucketLib mod and a user opened an issue some days ago: https://github.com/cech12/BucketLib/issues/45

There is a compatibility issue between my mod and Respiteful. This mod is registering fluids with your Registrate library and defines fluids without buckets: https://github.com/DragonsPlusMinecraft/Respiteful/blob/660d4480dfe74a0a2e617c4858ea7a9b792b01ce/src/main/java/plus/dragons/respiteful/entries/RespitefulFluids.java#L113

My mod is calling the getBucket() method for each fluid to identify fluids with buckets. During that call, an item "mint_green_tea_bucket" is searched in the registry (by your implementation), which crashes the game, because this item does not exist. But it should not be searched when the fluid is initialized with noBucket().

The PR #55 should fix this issue, but nothing happens since a year, so I open this issue.

I hope this issue reaches to you and you can at least fix this problem. Thanks a lot! :)