search

ttezel / twit

Twitter API Client for node (REST & Streaming API)
4.31k stars 568 forks source link

FileUploader: use correct highWaterMark field #462

Closed pthieu closed 8 months ago

pthieu commented 6 years ago

According to https://nodejs.org/docs/latest-v8.x/api/fs.html#fs_fs_createreadstream_path_options, the field name should be highWaterMark, uppercase M.

The chunks were actually defaulting to 64*1024, which causes longer upload times due to having a lot more requests, which means a higher total RTT.

pthieu commented 6 years ago

ping @ttezel

luanmuniz commented 6 years ago

ping @ttezel

skorasaurus commented 5 years ago

duplicate of https://github.com/ttezel/twit/pull/456 although this PR has a clearer commit message