search

ttgapers / cakeqos-merlin

Custom add-on for supported Asus routers with Merlin firmware that introduces CAKE QoS as an alternative to Traditional/Adaptive/FreshJR implementations.
https://www.snbforums.com/threads/release-cakeqos-merlin.64800/
GNU General Public License v3.0
62 stars 9 forks source link

After update go back to Cake-QOS Menu #44

Closed ttgapers closed 4 years ago

ttgapers commented 4 years ago

Not a high priority, but I am not sure if after running Cake update, it takes you back to the Menu that out to the shell prompt.

If it's not possible please close. If it is, we can track it here.

@Adamm00 your thoughts appreciated.

Adamm00 commented 4 years ago

Not possible. If you overwrite the script (aka update it) you have to immediately exit otherwise the shell will get confused on what line to execute and error out.

jackyaz commented 4 years ago

Can you not call "exec $0" and then exit the previous instance. That's how unbound_manager and my scripts handle reloads

Adamm00 commented 4 years ago

I can't seem to reproduce the issue which was present in commits prior to 38526b3493856a54e0e8313c17e2b277f35eb3d5 so I assume there are more specific circumstances that trigger this behavior (the same which I have previously experience in Skynet). With that being said, I've gone ahead and removed the hard exit in 7752ddcb4225953f5943d8952ecf3642879e1303 as it appears to be working correctly for now.