search

tth05 / morerefinedstorage

Continuation of RefinedStorage for 1.12 with focus on performance and new features.
MIT License
16 stars 7 forks source link

Crashing when using Refined Avaritia extreme pattern in crafter. #20

Closed lokep001 closed 3 years ago

lokep001 commented 3 years ago

Issue description:

Crashes when using extreme patterns

What happens:

I used Refined Avaritia to make a crafting pattern for crystaltine. Made the pattern and then put into crafter (above automation interface) and then server crashes.

What you expected to happen:

It wouldn't crash

Steps to reproduce:

  1. Make extreme pattern
  2. Put in crafter
  3. Kaboom ...

Version (make sure you are on the latest version before reporting):

Does this issue occur on a server? [yes/no] Don't know

If a (crash)log is relevant for this issue, link it here:

[pastebin/gist/etc link here] https://pastebin.com/YHiwpZnK

tth05 commented 3 years ago

Hey, sadly because of time constraints I stopped working on providing compatibility with old mods. The code base for this RS version has changed in a some parts which does lead to issues like this. This mod was initially made for private use, but I thought I could make it public if people want to use it.

lokep001 commented 3 years ago

Oh right, that's fine. Best of luck to you!

Pelotrio commented 3 years ago

Maybe in the future

lokep001 commented 3 years ago

Maybe in the future

well that would be great because then i could play exisiting expert packs on 1.12.2 with the new RS :D

lokep001 commented 3 years ago

Just tried RS large patterns and it also crashes with the same error and same way.

Edit: should’ve put crash log in https://pastebin.com/7APHNWF0

tth05 commented 3 years ago

I'll look at it tomorrow, maybe it's an easy fix

lokep001 commented 3 years ago

Thanks! RSLargePatterns is probably the better mod to look at as refined avaritia has been discontinued.

tth05 commented 3 years ago

Fixed in 9a2f2e4b85e35c67265bf526d69067573a6e5b96 New release soon

lokep001 commented 3 years ago

thank you so much :D this works with RSlargepatterns too? if so that would be great because that supports processing patterns too. but even if not so thank you so much for your work :D

tth05 commented 3 years ago

thank you so much :D this works with RSlargepatterns too? if so that would be great because that supports processing patterns too. but even if not so thank you so much for your work :D

I haven't tested it, but both mods work in a similar way so it could work.

tth05 commented 3 years ago

Release is out.

lokep001 commented 3 years ago

thank you so much :D this works with RSlargepatterns too? if so that would be great because that supports processing patterns too. but even if not so thank you so much for your work :D

I haven't tested it, but both mods work in a similar way so it could work.

yeah just tested it, works perfectly! Thanks :D