search

tth05 / morerefinedstorage

Continuation of RefinedStorage for 1.12 with focus on performance and new features.
MIT License
17 stars 7 forks source link

Incompatibility with More Refined Storage (not this mod) #22

Closed xemnes closed 3 years ago

xemnes commented 3 years ago

Issue description:

More Refined Storage which adds large disk drives is incompatible with this fork.

What happens:

game crashes when trying to use a disk from the More Refined Storage mod (not this mod) simply holding a disk from the addon caused the crash. https://www.curseforge.com/minecraft/mc-mods/more-refined-storage

Version (make sure you are on the latest version before reporting):

Does this issue occur on a server? [yes/no] yes

If a (crash)log is relevant for this issue, link it here:

https://paste.mod.gg/guyedapofi.mccrash

embeddedt commented 3 years ago

Heads up: https://github.com/tth05/morerefinedstorage/issues/20#issuecomment-782185354

One thing I am unsure of is why a 64 million item storage disk is necessary when mods like Storage Drawers and QuantumStorage exist. :confused:

xemnes commented 3 years ago

oh thats a pitty, i could attempt to do it myself then, though i guess i need to know what exactly changed to know how to fix it. guess loading up an ide will probably give me some info.

as for the big sotrage disk, the options there if i decide to use it, i do like the convenience of just chucking stuff in a massive storage box not having to worry about sorting.

embeddedt commented 3 years ago

If it's any help, the crash appears to be caused by a reference to the RS 1.6 migration helpers, which have been removed from this fork. I tried to find a GitHub repository for the mod so I could point you to where they were being used, but I couldn't find the repository.

xemnes commented 3 years ago

the repo for the addon? yeah sadly it doesnt seem to be open source. i have asked the dev if i could have the source, waiting for a response.

JayJay1989 commented 3 years ago

Its indeed closed source. Just dm me on discord, we can figure something out

tth05 commented 3 years ago

I guess I can add the class back with an empty implementation, this is pretty annoying :/

Pelotrio commented 3 years ago

Pretty ironic that morerefindstorage is not compatible with More Refined Storage

JayJay1989 commented 3 years ago

Pretty ironic that morerefindstorage is not compatible with More Refined Storage

Not quite, morerefinedstorage is a lot older than this mod and will probably break compatibility to the original and this forked version

Pelotrio commented 3 years ago

This fork removed some unnecessary stuff that older mods still depend on. What I sad was just a joke regarding the name nothing else. @JayJay1989

JayJay1989 commented 3 years ago

This can be closed https://www.curseforge.com/minecraft/mc-mods/more-refined-storage/files/3232011

tth05 commented 3 years ago

Nice!