search

tth05 / morerefinedstorage

Continuation of RefinedStorage for 1.12 with focus on performance and new features.
MIT License
17 stars 7 forks source link

Add CI workflow #39

Closed embeddedt closed 2 years ago

embeddedt commented 2 years ago

This is mostly for selfish reasons, so I don't have to recompile the mod locally every time you push a change. It also has the advantage of checking that PRs do actually compile.

tth05 commented 2 years ago

@embeddedt Just noticed it runs for each change in a PR as well, that's kind of annoying. Would you mind if I disable that?

embeddedt commented 2 years ago

@tth05 I mostly care about it for pushes to the main branch, so it's fine by me, but I'm curious what's annoying about it, as it shouldn't be sending any notifications unless it's failing.

tth05 commented 2 years ago

@tth05 I mostly care about it for pushes to the main branch, so it's fine by me, but I'm curious what's annoying about it, as it shouldn't be sending any notifications unless it's failing.

This is what I was thinking of:

embeddedt commented 2 years ago

You get notifications for successful workflow runs

I didn't realize (or have forgotten) that that is a feature. I guess I have it turned off. :slightly_smiling_face:

It wastes monthly github actions minutes

Public repositories have unlimited minutes as far as I know, since they're considered open-source.

It spams the actions tab with unnecessary workflow runs

Fair enough.

In any case, it doesn't bother me if you opt to disable that part.