tth05 / morerefinedstorage

Continuation of RefinedStorage for 1.12 with focus on performance and new features.
MIT License
17 stars 7 forks source link

Server crashes when crafting high amount of IC2 overclockers (and other random items) #50

Open lokep001 opened 2 years ago

lokep001 commented 2 years ago

Issue description:

Server crashes when I request autocraft of high amount of IC2 overclockers. It also crashed when someone on server autocrafted planks? It crashes as soon as you press the button after typing how many you want. (Pre-calculation screen).

Interestingly it only happens on the dedicated server. It has 10GB ram available so I don't really know.

What happens:

What you expected to happen:

It would go on the calculation screen and we can click start.

Steps to reproduce:

  1. Craft many items on a server.
  2. Watch it burn.
  3. ...

Version (make sure you are on the latest version before reporting):

Does this issue occur on a server? [yes/no] Yes, only on server

If a (crash)log is relevant for this issue, link it here:

For IC2 Overclockers: https://mclo.gs/N2aLqDq

For Wooden planks (I believe): https://mclo.gs/ZN4STrz [pastebin/gist/etc link here]

lokep001 commented 2 years ago

Thought it mightve been because i forgot to put fluid disks in. but it still happens --> https://mclo.gs/lKQJRtk#L11

Pelotrio commented 2 years ago

Rip I changed some things there in my last pr. Will probably check it out tomorrow.

lokep001 commented 2 years ago

Thanks :D

lokep001 commented 2 years ago

Yeah noticed it doesn't crash when i removed all external storages for fluid. Hope that helps.

Pelotrio commented 2 years ago

Yeah noticed it doesn't crash when i removed all external storages for fluid. Hope that helps.

Yes thats what I mean I changed the code for external storages in my pr to support longs so that my overloaded integration works. Everything I've tested so far worked with it but apparently I missed some.

Pelotrio commented 2 years ago

First issue is fixed in latest commit we are not quite sure about the second one yet. Will probably make a new release after that. You can ask me on discord if you want the version with just the current fix.

lokep001 commented 2 years ago

So the first issue is the suggestion right?