search

tthuem / VariantSync

Automating the synchronization of software variants
GNU Lesser General Public License v3.0
6 stars 2 forks source link

Create a preference view for factories #29

Open Kogoro opened 7 years ago

Kogoro commented 7 years ago

Which factory should be used when two factories can be used for a specific file? This should be settable within the preferences.

tthuem commented 7 years ago

Don't see a need for preferences so far. If there is only AST-based and line-based diff, AST-based should always be better. AST-based solution could indicate which extensions are supported.

Kogoro commented 7 years ago

As the factory is just an extension point there could be added more solutions by the time I think. The fallback will always be line-based diff and with only AST-based factories there could be no real reason for that, but I thought it should be considered for the future maybe even after the Masterarbeit milestone.

pmbittner commented 4 years ago

Thus should be investigated when joint work on AST based diffing is done and we start to implement AST-based diffing.

tthuem commented 4 years ago

Again, I doubt this is making it over-complicated. I would recommend using AST-based diff whenever available and only use line-based as a fallback. Shall we close this issue?