ttiimm / cymbol

5 stars 1 forks source link

Antlr4 grammar missing #1

Closed stevej2608 closed 4 months ago

stevej2608 commented 10 years ago

Hi,

The Antlr 4 grammar file is missing from the source tree. The derived A4 lexer & parser are in cymbol.jar but I cannot find the associated grammar.

Can you upload the grammar so the project can be built using the latest version of Antlr 4.

Thanks, Steve

ttiimm commented 10 years ago

Hi Steve,

The grammar file is located here:

https://github.com/ttiimm/cymbol/blob/master/src/cymbol/compiler/Cymbol.g

Let me know if there is anything else I could help with.

Tim

On Thu, Jan 9, 2014 at 12:02 PM, Steve Jones notifications@github.comwrote:

Hi,

The Antlr 4 grammar file is missing from the source tree. The derived A4 lexer & parser are in cymbol.jar but I cannot find the associated grammar.

Can you upload the grammar so the project can be built using the latest version of Antlr 4.

Thanks, Steve

— Reply to this email directly or view it on GitHubhttps://github.com/ttiimm/cymbol/issues/1 .

stevej2608 commented 10 years ago

Hi Tim,

Thanks for getting back. The Cymbol.g grammar is Antlr 3 not Antlr 4. The Antlr parser contained in cymbol.jar is an A4 parser so I figured it must have been generated from an A4 grammar (Cymbol.g4?).

I now know it's easy enough to convert the A3 grammar to A4 which is what I've done. As Terence Parr says "basically you just delete anything the A4 generator complains about". I was just worried that you might have enhanced/improved the grammar. If so I would not be able to pick up these changes.

Cheers, Steve

On 14/01/2014 21:06, ttiimm wrote:

Hi Steve,

The grammar file is located here:

https://github.com/ttiimm/cymbol/blob/master/src/cymbol/compiler/Cymbol.g

Let me know if there is anything else I could help with.

Tim

On Thu, Jan 9, 2014 at 12:02 PM, Steve Jones notifications@github.comwrote:

Hi,

The Antlr 4 grammar file is missing from the source tree. The derived A4 lexer & parser are in cymbol.jar but I cannot find the associated grammar.

Can you upload the grammar so the project can be built using the latest version of Antlr 4.

Thanks, Steve

— Reply to this email directly or view it on GitHubhttps://github.com/ttiimm/cymbol/issues/1 .

— Reply to this email directly or view it on GitHub https://github.com/ttiimm/cymbol/issues/1#issuecomment-32307376.

ttiimm commented 10 years ago

Ah OK. I wrote the grammar while Antlr was in a beta version. I don't recall which version though. But it was in Spring 2012 semester. I haven't had time to update with the latest release.

Tim On Jan 15, 2014 4:47 AM, "Steve Jones" notifications@github.com wrote:

Hi Tim,

Thanks for getting back. The Cymbol.g grammar is Antlr 3 not Antlr 4. The Antlr parser contained in cymbol.jar is an A4 parser so I figured it must have been generated from an A4 grammar (Cymbol.g4?).

I now know it's easy enough to convert the A3 grammar to A4 which is what I've done. As Terence Parr says "basically you just delete anything the A4 generator complains about". I was just worried that you might have enhanced/improved the grammar. If so I would not be able to pick up these changes.

Cheers, Steve

On 14/01/2014 21:06, ttiimm wrote:

Hi Steve,

The grammar file is located here:

https://github.com/ttiimm/cymbol/blob/master/src/cymbol/compiler/Cymbol.g

Let me know if there is anything else I could help with.

Tim

On Thu, Jan 9, 2014 at 12:02 PM, Steve Jones notifications@github.comwrote:

Hi,

The Antlr 4 grammar file is missing from the source tree. The derived A4 lexer & parser are in cymbol.jar but I cannot find the associated grammar.

Can you upload the grammar so the project can be built using the latest version of Antlr 4.

Thanks, Steve

— Reply to this email directly or view it on GitHubhttps://github.com/ttiimm/cymbol/issues/1 .

— Reply to this email directly or view it on GitHub https://github.com/ttiimm/cymbol/issues/1#issuecomment-32307376.

— Reply to this email directly or view it on GitHubhttps://github.com/ttiimm/cymbol/issues/1#issuecomment-32358362 .

ttiimm commented 4 months ago

Fixed with https://github.com/ttiimm/cymbol/pull/2