search

ttimbers / MWT_Locomotion_summary_analysis

Other
1 stars 2 forks source link

improved size functions flexibility and improved documentation #22

Closed quintinm-dev closed 9 years ago

quintinm-dev commented 9 years ago

Also removed error bars for size plots and added boxplot (as fmsb package for median C.I. is outdated)

ttimbers commented 9 years ago

@QMuncaster Looking better for the most part. I think we really want to avoid hard coding as much as possible so we can keep the reusability of our code high. What you have done for the plotting functions looks really good.

Before I merge this pull request, I'd like to see you make the mean.size() function more flexible. Right now it will break if your data frame doesn't have columns named area, length, width, ID, strain, timeor plate. Can the function also have the input of a list of things to aggregate over, a list of things to group by and the name of the column time.

ttimbers commented 9 years ago

Are you now done with the PR Quintin? Can I merge it?

quintinm-dev commented 9 years ago

Sorry not yet

ttimbers commented 9 years ago

no worries at all - just had time to look at it. Just let me know when it is done (no need to work on the weekend) :)

quintinm-dev commented 9 years ago

Dont merge this yet please; all the calls in main() work when I do them manually in RStudio, but whenever I try running the script from bash I get an error. Still trying to figure out what's happening.

quintinm-dev commented 9 years ago

Fixed - script works now