ttionya / vaultwarden-backup

Backup vaultwarden (formerly known as bitwarden_rs) SQLite3/PostgreSQL/MySQL/MariaDB database by rclone. (Docker)
MIT License
998 stars 115 forks source link

Suggestion: lvm snapshot instead of sqlite .backup #159

Closed nuuantoine closed 5 days ago

nuuantoine commented 1 month ago

I will try to implement it and will eventually post my solution for it, but Vaultwarden can now store organization event and backup of vaultwarden can take a huge amount of time because our sqlite db is 14GB for only 90 days of events. It would be very nice to have a way to :

What do you think about it ?

ttionya commented 1 month ago

I don't have extensive knowledge of LVM, but after researching, I found that to create an LVM snapshot, the files need to be on a LV (logical volume).

It means the vaultwarden data folder itself needs to be on a LV. However, vaultwarden does not require storing data on an LV. For users, placing data on a LV is an unnecessary operation. Additionally, this tool runs in a container and cannot start or stop another container.

In summary, using LVM snapshots would require users to migrate their data, introducing a breaking change, which this tool aims to avoid. Secondly, the backup process does not assume users need to stop their services. Thirdly, a container should not control the running state of another container (and perhaps it can't). Therefore, there are no plans to support LVM snapshot backups at this time.

Of course, if I have any misunderstandings about LVM, please correct me.

nuuantoine commented 1 month ago

That make sense with the way you see the product, we are using the scripts in a standalone way. I don't know if some people experience the same issue, but to me at the moment it seems like backing up sqlite when org event logs are enable is a bit complicated. and process fails after 10h+ of trying to do things. Thanks for the answer. :+1: