search

ttionya / vaultwarden-backup

Backup vaultwarden (formerly known as bitwarden_rs) SQLite3/PostgreSQL/MySQL/MariaDB database by rclone. (Docker)
MIT License
1.04k stars 119 forks source link

Location of BitwardenRS Data Directory as an Environment Variable #17

Closed obzerving closed 3 years ago

obzerving commented 3 years ago

If it wouldn't be too much of a hassle, could DATA_DIR be an environment variable? I've seen more than one set of installation instructions that used /data instead of /bitwarden/data.

ttionya commented 3 years ago

Thanks for the heads up, I will evaluate the workload and add the feature as soon as possible.

mustaphazorgati commented 3 years ago

If we use DATA_DIR as an environment variable we should also make RESTORE_DIR configurable.

@ttionya I don't think this is a lot of work. Shall I do it?

ttionya commented 3 years ago

If we use DATA_DIR as an environment variable we should also make RESTORE_DIR configurable.

@ttionya I don't think this is a lot of work. Shall I do it?

Thanks, I am working on this change.

obzerving commented 3 years ago

Thanks for your consideration of this request.

mustaphazorgati commented 3 years ago

Hey @ttionya! I just saw that you fixed this issue. Can you please extend the README so that new users know how to override the default data directory and other variables? Thanks!

ttionya commented 3 years ago

Hey @obzerving ,

I released v1.6.0 and you can specify the data directory by modifying the environment variable.

But I think you need to modify it only when you use automatic backup, please check your usage scenario to avoid using it by mistake.

Please let me know if you have any problem.

ttionya commented 3 years ago

Hey @ttionya! I just saw that you fixed this issue. Can you please extend the README so that new users know how to override the default data directory and other variables? Thanks!

I have added the description.

obzerving commented 3 years ago

I am indeed using automatic backup, so v1.6.0 should resolve the issue for me. Thanks, again.