ttionya / vaultwarden-backup

Backup vaultwarden (formerly known as bitwarden_rs) SQLite3/PostgreSQL/MySQL/MariaDB database by rclone. (Docker)
MIT License
1.04k stars 119 forks source link

added compatibility for special characters in rclone remote #6

Closed mustaphazorgati closed 3 years ago

mustaphazorgati commented 3 years ago

After setting up I've encountered a problem because by rclone remote contained a space.

Log:

Starting bitwarden_backup_1 ... done
Attaching to bitwarden_backup_1
backup_1     | ========================================
backup_1     | CRON: 55 * * * *
backup_1     | RCLONE_REMOTE_NAME: Google Drive
backup_1     | RCLONE_REMOTE_DIR: /
backup_1     | RCLONE_REMOTE: Google Drive:/
backup_1     | ZIP_ENABLE: TRUE
backup_1     | ZIP_PASSWORD: X Chars
backup_1     | BACKUP_KEEP_DAYS: 7
backup_1     | MAIL_SMTP_ENABLE: TRUE
backup_1     | MAIL_TO: XXX
backup_1     | MAIL_WHEN_SUCCESS: TRUE
backup_1     | MAIL_WHEN_FAILURE: TRUE
backup_1     | TIMEZONE: Europe/Berlin
backup_1     | ========================================
backup_1     | Usage:
backup_1     |   rclone mkdir remote:path [flags]
backup_1     | 
backup_1     | Flags:
backup_1     |   -h, --help   help for mkdir
backup_1     | 
backup_1     | Use "rclone [command] --help" for more information about a command.
backup_1     | Use "rclone help flags" for to see the global flags.
backup_1     | Use "rclone help backends" for a list of supported services.
backup_1     | Command mkdir needs 1 arguments maximum: you provided 2 non flag arguments: ["Google" "Drive:/"]
backup_1     | storage system connection failure

I've escaped all calls of RCLONE_REMOTE. This should do the trick. I didn't test it tho.