ttjoseph / adthwart-googlecode

The old Google Code issues for adthwart - of historical interest only
0 stars 1 forks source link

Memory leak using CricInfo website #126

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Please give a precise description of the problem and steps to reproduce it.
I was on
http://www.cricinfo.com/england-v-bangladesh-
2010/engine/current/match/426401.

Observing the Google Chrome Task Manager, I notice the memory on the tab 
steadily climb, especially when the website is communicating with its 
server.
It eventually reached > 1GB (after a few hours)!
This doesn't happen when I turn AdThwart off, and it does happen when 
AdThwart is the only extension running, which is how I concluded that it's 
a problem with AdThwart.

At which URL is this problem observed?
http://www.cricinfo.com/england-v-bangladesh-
2010/engine/current/match/426401.html

Which versions of AdThwart, Chrome and Windows/MacOS/Linux?
AdThwart 0.9.6
Chrome 5.0.375.55 beta

Which filter lists are you subscribed to? Any custom filters?
EasyList
AdThwart General Filters

In AdThwart Options, which "General" options are checked?
Disable inline text ads

Original issue reported on code.google.com by tim.bel...@gmail.com on 28 May 2010 at 4:08

GoogleCodeExporter commented 9 years ago
Thanks for reporting. Looks like that page inserts DOM elements continuously, 
which triggers an ad removal pass 
each time, which allocates new arrays every time. Javascript is 
garbage-collected but there is an explicit delete 
statement which I've added to that part of the code. Please try 0.9.8.

Original comment by ttjos...@gmail.com on 28 May 2010 at 5:00

GoogleCodeExporter commented 9 years ago
I've had another go with AdThwart 0.9.8
The environment isn't quite the same - I'm on a different machine using Chrome
5.0.375.55 (stable rather than beta) but still Windows XP
However, memory usage still climbs with AdThwart on (went to ~50MB after a bit 
over
an hour) and is steady (~20MB climbing to ~25MB over the same period) with 
AdThwart off.
That might mean that it is climbing more slowly than before, but since I am 
using a
different machine (and the cricket commentary hadn't started when I tested with
AdThwart on, so that may have affected the amount of information passing 
between my
computer and the CricInfo server) I don't know whether the figures are 
comparable.
I'm afraid that my javascript isn't good enough to be able to work out a minimal
reproduction for you :-(

Original comment by tim.bel...@gmail.com on 29 May 2010 at 11:36

GoogleCodeExporter commented 9 years ago
Issue 268 has been merged into this issue.

Original comment by ttjos...@gmail.com on 25 Oct 2010 at 10:08