ttjoseph / adthwart-googlecode

The old Google Code issues for adthwart - of historical interest only
0 stars 1 forks source link

Even when whitelisted, ajax chat does not scroll properly with adthwart enabled. #314

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Please give a precise description of the problem and steps to reproduce it.

Essentially, when adthwart is running, the chat will not scroll all the way to 
the bottom when new lines appear...instead, it scrolls to, strangely, the line 
above the bottom (roughly). 

Disabling adthwart makes the problem go away, but the problem is there when 
adthwart is running (even without any other extensions running).

I figured whitelisting the domain (and it is properly showing as allowed) would 
make the issue go away, but that doesn't - whatever whitelisting does, it 
doesn't completely stop processing for the site.

At which URL is this problem observed?
The site in question that I'm using is at http://xnachat.com.  

Which versions of AdThwart, Chrome and Windows/MacOS/Linux?
AdThwart: 1.0.15
Chrome: 8.0.552.200 beta
Windows 7 x64

Which filter lists are you subscribed to? Any custom filters?
The defaults -EasyList and AdThwart recommended...however, turning off EasyList 
doesn't make the issue go away.

Only the 2 default custom filters:
qux.us###annoying_AdDiv and qux.us##.ad_class

In AdThwart Options, which "General" options are checked?
All 4

Please provide any additional information below.

At the "easiest", one would think that simply removing any processing from a 
page that is whitelisted would do the trick, though it'd be nice if I didn't 
have to bother.  There are no ads on the site, though, so I would, personally, 
be fine with that :)

Original issue reported on code.google.com by dril...@gmail.com on 20 Nov 2010 at 9:04

GoogleCodeExporter commented 9 years ago
Thanks for reporting. This is a manifestation of a Chrome issue. I've added a 
workaround that will be in the next release of AdThwart:

https://github.com/ttjoseph/adthwart/commit/a7e9320

Original comment by ttjos...@gmail.com on 20 Nov 2010 at 3:57

GoogleCodeExporter commented 9 years ago
Thanks for the quick reply!  Question: is it possible for whitelisted sites to 
be added to that BEFORELOAD_MALFUNCTION_DOMAINS automatically...i.e. "don't 
listen for the beforeload on any whitelisted sites?"  

Seems like that would be a better workaround for you - that way, you wouldn't 
have to keep adding sites into it until chrome fixes it (though, thanks for 
adding xnachat to it!), you could just direct people to add the sites to the 
whitelist to solve the issue.  

Maybe it's not possible with your architecture, but it's just a thought!

Anyway, thanks again!

Original comment by dril...@gmail.com on 20 Nov 2010 at 7:14

GoogleCodeExporter commented 9 years ago
Checking the stored settings for a list of these domains requires an 
asynchronous API call that returns when Chrome feels like it. In the meantime a 
bunch of ads could be missed. Unfortunately I don't know of a way to check 
settings synchronously (as can be done in Safari) which would fix this problem 
and improve the quality of ad blocking in general.

Original comment by ttjos...@gmail.com on 20 Nov 2010 at 7:20

GoogleCodeExporter commented 9 years ago
That certainly makes sense.  Thanks for taking the time to explain!  And 
thanks, of course, for adthwart, it does a fantastic job :)

Original comment by dril...@gmail.com on 20 Nov 2010 at 7:25