Closed GoogleCodeExporter closed 9 years ago
Thanks for reporting. This is a manifestation of a Chrome issue. I've added a
workaround that will be in the next release of AdThwart:
https://github.com/ttjoseph/adthwart/commit/a7e9320
Original comment by ttjos...@gmail.com
on 20 Nov 2010 at 3:57
Thanks for the quick reply! Question: is it possible for whitelisted sites to
be added to that BEFORELOAD_MALFUNCTION_DOMAINS automatically...i.e. "don't
listen for the beforeload on any whitelisted sites?"
Seems like that would be a better workaround for you - that way, you wouldn't
have to keep adding sites into it until chrome fixes it (though, thanks for
adding xnachat to it!), you could just direct people to add the sites to the
whitelist to solve the issue.
Maybe it's not possible with your architecture, but it's just a thought!
Anyway, thanks again!
Original comment by dril...@gmail.com
on 20 Nov 2010 at 7:14
Checking the stored settings for a list of these domains requires an
asynchronous API call that returns when Chrome feels like it. In the meantime a
bunch of ads could be missed. Unfortunately I don't know of a way to check
settings synchronously (as can be done in Safari) which would fix this problem
and improve the quality of ad blocking in general.
Original comment by ttjos...@gmail.com
on 20 Nov 2010 at 7:20
That certainly makes sense. Thanks for taking the time to explain! And
thanks, of course, for adthwart, it does a fantastic job :)
Original comment by dril...@gmail.com
on 20 Nov 2010 at 7:25
Original issue reported on code.google.com by
dril...@gmail.com
on 20 Nov 2010 at 9:04