search

ttjoseph / adthwart-googlecode

The old Google Code issues for adthwart - of historical interest only
0 stars 1 forks source link

AdThwart recommended filters is ALWAYS enable #317

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Please give a precise description of the problem and steps to reproduce it.
AdThwart recommended filters is ALWAYS enable, no matter what filter or option 
the user selects.

I use a custom list of mine, other lists are disabled.

At which URL is this problem observed?
ALL

Which versions of AdThwart, Chrome and Windows/MacOS/Linux?
chrome dev 9.0.591 build 66875 / Windows

Which filter lists are you subscribed to? Any custom filters?
Pls refer to 1st question

In AdThwart Options, which "General" options are checked?
No matter what options are checked, issue persists

Please provide any additional information below.

Original issue reported on code.google.com by fastfred...@gmail.com on 20 Nov 2010 at 7:59

GoogleCodeExporter commented 9 years ago 
I found some insights about this in the code's comments:
> We do this because server issues with adthwart.qux.us caused 404 errors for 
some
> users and options.html will disable lists that aren't found on the server.
> So we may have lost some users who may not have noticed. Anyway everybody 
should
> have the recommended filters enabled. This change still allows disabling for 
the
> current session, but next time AdThwart is reloaded it will be reenabled.

Original comment by uarcan...@gmail.com on 21 Nov 2010 at 12:39

GoogleCodeExporter commented 9 years ago 
The fact to always enable a certain filter, I don't think thats a good idea: 
too many filters will slow down the browsing experience. To avoid that, I use a 
custom set of filters (around 1kb).

However I found a very simple workaround: I edited recomended filter url, 
replacing it with my list.

Original comment by fastfred...@gmail.com on 22 Nov 2010 at 7:16

GoogleCodeExporter commented 9 years ago 
This was a temporary thing - I'll be disabling the always-on behavior in the 
next release.

Original comment by ttjos...@gmail.com on 22 Nov 2010 at 12:52

GoogleCodeExporter commented 9 years ago 
OK, this has been reverted and things will be back to normal in the next 
release:

https://github.com/ttjoseph/adthwart/commit/f51cd45

Original comment by ttjos...@gmail.com on 23 Nov 2010 at 12:07