cannot use blocker to create filter

ttjoseph / adthwart-googlecode

The old Google Code issues for adthwart - of historical interest only

0 stars 1 forks source link

cannot use blocker to create filter #328

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Please give a precise description of the problem and steps to reproduce it.

At which URL is this problem observed?
any pages

Which versions of AdThwart, Chrome and Windows/MacOS/Linux?
1.0.18

Which filter lists are you subscribed to? Any custom filters?
this is blocker issue not filter issue

In AdThwart Options, which "General" options are checked?
default setting

Please provide any additional information below.
the block can only create filter for image ads.

Original issue reported on code.google.com by tailinchu on 25 Nov 2010 at 6:17

GoogleCodeExporter commented 9 years ago

https://github.com/ttjoseph/adthwart/commit/29532dd60acf6908e9ff73ccede9c7651543
2086

please check this commit

Original comment by tailinchu on 25 Nov 2010 at 6:20

GoogleCodeExporter commented 9 years ago

still not working properly with 1.0.19

Original comment by tailinchu on 28 Nov 2010 at 11:44

GoogleCodeExporter commented 9 years ago

The context menu API does not return the specific element the user clicked on, 
so for the time being I've restricted it to only image and HTML5 video tags, 
which makes it easier to guess what the user really wanted to block.

Original comment by ttjos...@gmail.com on 28 Nov 2010 at 11:54

Added labels: Type-Enhancement
Removed labels: Type-Defect

GoogleCodeExporter commented 9 years ago

This is not for context menu but for regular filter-creating blocker.

Original comment by tailinchu on 29 Nov 2010 at 12:01

GoogleCodeExporter commented 9 years ago

Confirmed, since 1.0.18 it works, with latest .19 it wont work anymore.
Context menu works, the easy creation icon in urlbar wont anymore.

Original comment by fastfred...@gmail.com on 29 Nov 2010 at 6:23

GoogleCodeExporter commented 9 years ago

Does 1.0.20 help?

Original comment by ttjos...@gmail.com on 29 Nov 2010 at 11:59

Added labels: Type-Defect
Removed labels: Type-Enhancement

GoogleCodeExporter commented 9 years ago

yes, it is ok with 1.0.20

Original comment by tailinchu on 30 Nov 2010 at 12:16

GoogleCodeExporter commented 9 years ago

Great, thanks.

Original comment by ttjos...@gmail.com on 30 Nov 2010 at 12:17

Changed state: Fixed