search

ttjoseph / adthwart-googlecode

The old Google Code issues for adthwart - of historical interest only
0 stars 1 forks source link

Simple rule incorrectly kills almost entire page #354

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Please give a precise description of the problem and steps to reproduce it.
One filter rule (present in ruadlist) makes the website almost empty even 
though it's only supposed to catch the ad script: "an.yandex."

At which URL is this problem observed?
http://forum.exler.ru/index.php?showforum=126

Which versions of AdThwart, Chrome and Windows/MacOS/Linux?
1.0.21, 8.0.552.224 beta, Windows 7 x64

Which filter lists are you subscribed to? Any custom filters?
Custom rule "an.yandex." or RuAdList

In AdThwart Options, which "General" options are checked?
All

Please provide any additional information below.
Adblock works correctly with the same ruleset.

Original issue reported on code.google.com by mkat...@gmail.com on 16 Dec 2010 at 4:14

GoogleCodeExporter commented 9 years ago 
Is it related to http://code.google.com/p/adthwart/issues/detail?id=227 ?

Original comment by mkat...@gmail.com on 16 Dec 2010 at 5:43

GoogleCodeExporter commented 9 years ago 
I think this the beforeload WebKit bug...

Original comment by ttjos...@gmail.com on 20 Dec 2010 at 3:04

GoogleCodeExporter commented 9 years ago 
I don't think it is. That bug seems to only happen to images. This one removes 
everything.

Original comment by mkat...@gmail.com on 20 Dec 2010 at 9:14

GoogleCodeExporter commented 9 years ago 
This is definitely NOT that bug. It has something to do with asynchronous 
blocking of the ad javascript. If I add 'third-party' to the rule so that it's 
blocked synchronously, everything works fine. 

Probably something that script does breaks the page, so it's not exactly the 
adthwart (adblock :)) problem. Still, maybe you need to implement some 
workaround?

Original comment by mkat...@gmail.com on 20 Dec 2010 at 9:57

GoogleCodeExporter commented 9 years ago 
Hm. If I add "forum.exler.ru" to BEFORELOAD_MALFUNCTION_DOMAINS in 
initial-block.js, the site works. Are you able to check whether this helps you? 
The beforeload bug has the potential to affect more than just images, I 
suppose...

Original comment by ttjos...@gmail.com on 20 Dec 2010 at 10:01

GoogleCodeExporter commented 9 years ago 
Can't check it right now, will do tomorrow. 

However this is not a viable workaround since the script that causes problems 
is a very popular russian text ad network (russian alternative to google 
adsense) and is on many websites (causes the same problem to them, too). So any 
solution has to deal with the script, not sites that use it. 

If it is indeed the problem with this specific ad script, I guess it would be 
the best to either ask ruadlist maintainers to add 'third-party' to the rule or 
add it to the chrome_supplement.txt.

Original comment by mkat...@gmail.com on 21 Dec 2010 at 10:22

GoogleCodeExporter commented 9 years ago 
Script in question: http://an.yandex.ru/resource/context.js

Original comment by mkat...@gmail.com on 21 Dec 2010 at 10:22

GoogleCodeExporter commented 9 years ago 
Re: comment 5. Yes, it does help. Still, the beforeload handler by itself is 
not the source of the problem. It's the asynchronous blocking that lets the 
script load before removing it that causes the problem.

Original comment by mkat...@gmail.com on 21 Dec 2010 at 11:00