ttjoseph / adthwart-googlecode

The old Google Code issues for adthwart - of historical interest only
0 stars 1 forks source link

Youtube ad blocking #359

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
When youtube advert blocking is enabled, the vidoe plavyer disappears, and is 
replaced with a grey box.

youtube.com

latest version of adthwart, ubuntu 10.10 and chrome 8.0.552.224

I have some custom filters enabled, but not on youtube.

All general options are enabled.

Original issue reported on code.google.com by me.jfle...@gmail.com on 18 Dec 2010 at 9:25

GoogleCodeExporter commented 9 years ago
YouTube ad blocking has been reworked. There will be a new development build on 
https://adblockplus.org/devbuilds/adblockpluschrome/ in 20 minutes, please try 
it and tell us whether it resolves the issue. Please note that the development 
build installs in parallel to the release version, the release version needs to 
be disabled.

Original comment by trev%adb...@gtempaccount.com on 9 Feb 2011 at 8:31

GoogleCodeExporter commented 9 years ago
The new development build fixes one problem, but unfortunately introduces a new
one. I'm seeing a black rectangle where the video should be. The console reads:

DOMException
code: 8
message: "NOT_FOUND_ERR: DOM Exception 8"
name: "NOT_FOUND_ERR"

Original comment by chrishan...@live.com on 14 Mar 2011 at 5:29

GoogleCodeExporter commented 9 years ago
I have doubts that your issue is related to the one reported here - but ok, it 
is similar enough, let's try to deal with it here. Given that I cannot 
reproduce your problem, it would be nice to get some additional information:

1) Which file name/line number is referenced in the console for this error 
message?
2) Which particular video?
3) Does it happen every time or only sometimes?
4) Does it work if you disable "Block ads inside YouTube videos" in Adblock 
Plus options (under "General")?

Original comment by trev%adb...@gtempaccount.com on 14 Mar 2011 at 8:05

GoogleCodeExporter commented 9 years ago
Not got a single problem with the latest version. Also using the latest stable 
version of Chrome.

Original comment by me.jfle...@gmail.com on 14 Mar 2011 at 5:12

GoogleCodeExporter commented 9 years ago
Good, fixed then.

@chrishandon: Since this issue is resolved, let's not continue here. Please 
create a topic under https://adblockplus.org/forum/viewforum.php?f=10 
(registration not required) and answer my questions there.

Original comment by trev%adb...@gtempaccount.com on 14 Mar 2011 at 8:41

GoogleCodeExporter commented 9 years ago
>> Good, fixed then.
No. It is not fixed.

>> Not got a single problem with the latest version.
@trev: Hold on one second... Is this the kind of feedback that goes into your
testing metric?! You can't be serious. It took you no less than 13 hours to dump
my feedback, yet I included specific details about the problem ... Oh, I see.
Once the software is labeled as "perfect", any issues encountered thereafter are
irrelevant.

>> Given that I cannot reproduce your problem [...]
But I can. I'd advise your quality assurance staff to employ better techniques
for testing.

>> I have doubts that your issue is related to the one reported here [...]
Grey box, black box; replaced plavyer, missing plavyer; sounds the same to me.
Given what I've said so far, nobody can blame you for having your doubts.

If you don't want people reporting issues here, then why is this page still
accepting reports? Perhaps you should hide the issues page. And since you posted
a notice about the new build, doesn't that mean this issue regarding YouTube
still carries over?

Please do not avoid the issue. You have a responsibility to handle problems
caused by this software.

Original comment by chrishan...@live.com on 16 Mar 2011 at 12:09

GoogleCodeExporter commented 9 years ago
Since you apparently didn't bother to read my comments: this issue *as 
reported* is fixed. jfletch reported the issue and he also confirmed that 
things are working now - and that's pretty much the definition of "fixed". Now 
*your* comments are a) off topic and b) not reproducible. Which means that you 
should: a) create your own issue report (and please not in this project, 
Adblock Plus forum is the place where issue reports should go into now) and b) 
answer the questions I asked. Offending me won't help your cause - I cannot fix 
an issue that I cannot reproduce. While your comment includes some details they 
are not enough to pinpoint the problem.

PS: Please don't tell me how to manage issues - I merge issues if I am certain 
that they are talking about the same problem. And the three issues you 
commented in all look like different issues to me, I merely managed to fix all 
of them in the same set of changes.

Original comment by trev%adb...@gtempaccount.com on 16 Mar 2011 at 7:29