search

ttk-cli / uni-vue3-vite-ts-pinia

A template for uniapp with vue3.
MIT License
358 stars 106 forks source link

fix: first commit-lint error and update typescript deps #40

Closed warmthsea closed 1 year ago

warmthsea commented 1 year ago

Typescript version conflicts with other plugins.

0ec6f5497b2a2d687fbc9416d5ebb789

If use template of download zip，first commit-lint is error.

bc50835dcab1efc1f25926b7973b0c2f da7759bd47ef0bdc0abe3350715a5aa4

Allen-1998 commented 1 year ago
  1. This project uses npm i and node16.x by default, so there are no dependency conflicts when installing dependencies, but they do happen with pnpm, so upgrading to typescript 4.9.5 is a good idea.
  2. When downloading zig, the .git folder will not be generated, which will cause postinstall to fail when installing dependencies for the first time. This should be the cause of commit-lint failure, I think this can be added in FAQ.md.

image

Allen-1998 commented 1 year ago

npm is still more generic today than pnpm, and it's not a good idea to include two lock files in the same project. It increases the risk of different people installing minor dependencies in the same project, but feel free to talk again if you disagree.