ttlappalainen / NMEA0183

Library for handling NMEA0183 messages
76 stars 48 forks source link

Dataline-X compatibility #10

Closed W0153R closed 5 years ago

W0153R commented 5 years ago
ttlappalainen commented 5 years ago

Hi,

Some hints:

class tNMEA0183 { public: enum tChecsumCheck={cc_Automatic, cc_NoCheck, cc_Force}; ...

bool NMEA0183SetRMB(tNMEA0183Msg &NMEA0183Msg, tRMB RMB, const char *Src="GP");

causes explicit copy for whole RMB structure, which is pretty big. So it is better to use

bool NMEA0183SetRMB(tNMEA0183Msg &NMEA0183Msg, const tRMB &RMB, const char *Src="GP");

So that only reference to structure will be copied as parameter. There is no difference of use the parameter itself.