NMEA checksum should accept lowercase

ttlappalainen / NMEA0183

Library for handling NMEA0183 messages

69 stars 44 forks source link

NMEA checksum should accept lowercase #34

Open wellenvogel opened 2 years ago

wellenvogel commented 2 years ago

It seams that some manufacturers are sending the NMEA checksum using lower case characters for a...f. So It would be good of the library would also accept them in the checksum.

orca-hydromancer commented 2 years ago

https://github.com/orca-io/NMEA0183/commit/706cd2e0ba9ff3b17e4a139dc059a2177787dc78#diff-f880fa56145617b3efb131530a19dc1d2597d8065cc5b6281f8860cbb2925aaaR108

Never got around to creating a PR

ttlappalainen commented 2 years ago

This has been fixed already on last summer, but for some reason I had not pushed it to github. Now it is there wit some other updates I had on my own code.