search

ttlappalainen / NMEA0183

Library for handling NMEA0183 messages
69 stars 44 forks source link

Unit problem in ROT (and others?) #37

Open speters opened 2 years ago

speters commented 2 years ago

NMEA0183ParseROT_nc and NMEA0183SetROT deliver/expect radians as angle unit. But the change rate is still per minute. I think this should be converted to 1/s to keep in line with SI and what NMEA2k expects.

https://github.com/ttlappalainen/NMEA0183/blob/4f4981ea84bd3b9ef65b948af7e6c96c80a08deb/NMEA0183Messages.cpp#L528

https://github.com/ttlappalainen/NMEA0183/blob/4f4981ea84bd3b9ef65b948af7e6c96c80a08deb/NMEA0183Messages.cpp#L536

ttlappalainen commented 2 years ago

Value should be converted to rad/s so it should be RateOfTurn=NMEA0183GetDouble(NMEA0183Msg.Field(0),degToRad/60);