step-by-step

[AndrasSzep]

want to implement some additional functions i.e. RPM, MWD and MTW so first just to have a compatible start

[ttlappalainen]

What is the point of reformat everthing and cause unnecessary changes? E.g., I like more style tBoatData() { than tBoatData() {

Also there is several commits for simple add. make your code ready and tested before commiting. And then do it with one clean commit with title and description of changes.

Remove this PR.

[AndrasSzep]

Sorry Timo, the reformatting is done by the visual studio code. My goal was basically to check compatibility as last time it turned out that I used a quite old version of you repo which was but forward compatible. I am making some additions like water temp, engine rpm, etc. When ready tested will send you.

Kind regards and ask the best

Andras

On Thu, 26 Jan 2023 at 12:14, Timo Lappalainen @.***> wrote:

What is the point of reformat everthing and cause unnecessary changes? E.g., I like more style tBoatData() { than tBoatData() {

Also there is several commits for simple add. make your code ready and tested before commiting. And then do it with one clean commit with title and description of changes.

Remove this PR.

— Reply to this email directly, view it on GitHub https://github.com/ttlappalainen/NMEA0183/pull/42#issuecomment-1404917654, or unsubscribe https://github.com/notifications/unsubscribe-auth/AONEQRD3UTU5IE3HLY2M3DLWUJTARANCNFSM6AAAAAAUG3BKPE . You are receiving this because you authored the thread.Message ID: @.***>

-- András

[ttlappalainen]

• Make minimal changes and no unnecessary formatting.
• Code should be backward compatible. So same old . ino should compile with old and new version.
• I prefer to have single PR clean. So you should make your code first ready and then pull. Now it is very difficult to follow changes, since there is 19 different commit and all commits will be copied to my repo. So clean it so that there is only commit and minimal changes.