forty76 commented 1 month ago

Hello, thank you for your fantastic libraries

Unfortunately Arduino detects several errors when using the new ESP32 (S2,S3,C3). I'm currently trying sergei/NMEA2000_esp32_twai (https://github.com/sergei/NMEA2000_esp32_twai)

You could implement the right libraries for the various devices in the NMEA2000_CAN.h file.

elif USE_N2K_CAN == USE_N2K_ESP32_CAN

if CONFIG_IDF_TARGET_ESP32S2

 #include <NMEA2000_esp32_twai.h>
 tNMEA2000 &NMEA2000=*(new NMEA2000_esp32_twai());

elif CONFIG_IDF_TARGET_ESP32S3

 #include <NMEA2000_esp32_twai.h>
 tNMEA2000 &NMEA2000=*(new NMEA2000_esp32_twai());

elif CONFIG_IDF_TARGET_ESP32

 #include <NMEA2000_esp32.h>
 tNMEA2000 &NMEA2000=*(new tNMEA2000_esp32());

else

 #error "Unrecognized ESP."

endif

ttlappalainen commented 1 month ago

I won't, since it does not use properly my library.

unxs0 commented 2 weeks ago

I won't, since it does not use properly my library.

Can we crowd fund the work needed to get esp32-s3 support?

ttlappalainen commented 1 week ago

Do you need it personally or commercially? Why S3?

unxs0 commented 1 week ago

Hi Timo!

The few manufacturers of low cost boat usable AMOLED displays only use this MCU for products and/or on their development kit boards.

They are DWO and their client LilyGo.

https://www.lilygo.cc/products/t4-s3 (https://www.lilygo.cc/products/t4-s3)

https://www.dwo.net.cn/pr.jsp?_pp=0_316_1_-1 (https://www.dwo.net.cn/pr.jsp?_pp=0_316_1_-1)

Plus the only good quality low cost easy to use graphics library LVGL adds extra problems, interfering in some way with TWAI on the Expressif S3. This is possibly due to some error in the Espxx lib that at least compiles and runs (fails after some time when LVGL controls SPI) with your excellent NMEA2000 library.

It is for an open source boating mini multifunction display project. And of course it should be completely libre software part of your esp32 extensión.

Cheers, Gary

June 17, 2024 1:59 AM, "Timo Lappalainen" @. @*.**@*.***>)> wrote: Do you need it personally or commercially? Why S3?

—

Reply to this email directly, view it on GitHub (https://github.com/ttlappalainen/NMEA2000_esp32/issues/25#issuecomment-2172241019), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AELSHMQNHLXOHY7F634ZL2LZHZUKLAVCNFSM6AAAAABICGOVRGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZSGI2DCMBRHE). You are receiving this because you commented.Message ID: @.***>

ibravo commented 1 week ago

+1 for adding support to the Lilygo T Display S3 board. These are great boards that have an attached screen, thus able to display the data on the same board, making it great for a small footprint device. I'm also using it for personal use, to attach to the NMEA2k network and display the results in the little screen.

ttlappalainen / NMEA2000_esp32