ttm / cefpython

Automatically exported from code.google.com/p/cefpython
0 stars 0 forks source link

Patch providing CEF3 GetSource(), GetText() and general StringVisitor support #96

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The attached patch adds support to CEF3 cefpython for the GetSource() and 
GetText() methods. These methods are asynchronous in CEF3 unlike in CEF1.

StringVisitor C++/Python classes are added and used to call into a Visit() 
method to cef to be asynchronously called when it has the page source or text 
ready to be returned.

This is used to pass the returned source or text into a user's python program.

wxpthon.py and wxpython.html have been modified to demonstrate both methods 
with javascript calls to dump page source or page text to console.

Original issue reported on code.google.com by gregfarr...@gmail.com on 28 Nov 2013 at 4:30

Attachments:

GoogleCodeExporter commented 9 years ago
Patch looks good, thanks Greg. Some comments below.

StoreUserStringVisitor, GetPyStringVisitor, PyStringVisitor and 
makeStringVisitor should go to the string_visitor_cef3.pyx file.

In the wxpython example there should be a comment about keeping a strong 
reference to the StringVisitor object during the visit.

I will make these changes when patching.

Original comment by czarek.t...@gmail.com on 25 Dec 2013 at 1:37

GoogleCodeExporter commented 9 years ago
Patch applied with minor modifications in revision be7029d302f3.

Updated wiki pages: Frame, StringVisitor, Changelog3.

Original comment by czarek.t...@gmail.com on 26 Dec 2013 at 9:14

GoogleCodeExporter commented 9 years ago
Version 29.2 for Windows released with all your patches applied. Version for 
Linux will appear in a few days, also I plan on introducing debian packages.

Original comment by czarek.t...@gmail.com on 26 Dec 2013 at 9:21