search

ttrftech / NanoVNA

Very Tiny Palmtop Vector Network Analyzer
1.06k stars 296 forks source link

Fix freq commands (parsed as int), more compact code #118

Closed DiSlord closed 4 years ago

DiSlord commented 4 years ago

Fix freq commands (parsed as int), more compact code

DiSlord commented 4 years ago

I think need remove uint32_t _frequencies[POINTS_COUNT]; from properties_t

And calculate it on fly (not use float digit)

Its allow save big size of ram, and rom (and config size on flash)

edy555 commented 4 years ago

I think need remove uint32_t _frequencies[POINTS_COUNT]; from properties_t And calculate it on fly (not use float digit) Its allow save big size of ram, and rom (and config size on flash)

Exactly. It might be possible. I'll think about it.

DiSlord commented 4 years ago

I can`t upload my version chprintf.c to ChibiOS\os\hal\lib\streams upload it to root :(

edy555 commented 4 years ago

Awesome update, great!

BTW, the change below makes trouble, could you remove from this PR. image

edy555 commented 4 years ago

This update seems to contain LF+CR. It is better using only LF.

DiSlord commented 4 years ago

Seems better recreate pull Request or fork, i get errors on fix it (In last commit i revert all changes to ChibiOS, and get errors)

edy555 commented 4 years ago

I see, place PR again, please.