search

ttrftech / NanoVNA

Very Tiny Palmtop Vector Network Analyzer
1.06k stars 296 forks source link

Nonsense calibration if sweep is paused before the calibration #123

Open yarda opened 4 years ago

yarda commented 4 years ago

Reproducer:

  1. pause sweep (stimulus/pause sweep)
  2. do all calibration steps while the sweep is paused (cal/calibrate)

This will result in nonsense calibration and very long numbers for SWR (with many digits overflowing the display width).

The firmware should either unpause the sweep before the calibration or inform user that the calibration cannot be done with the paused sweep (and it shouldn't allow to proceed).

yarda commented 4 years ago

FW 0.7.0-20200223

DiSlord commented 4 years ago

Thanks, i add sweep operation for collect data in next Pull Request to fix it

DiSlord commented 4 years ago

Revert add this feature, need find better solution :(