search

ttrftech / NanoVNA

Very Tiny Palmtop Vector Network Analyzer
1.09k stars 305 forks source link

missing group delay and phase delay measurements #64

Closed qrp73 closed 5 years ago

qrp73 commented 5 years ago

There is exists trace format DELAY in the menu, but it doesn't works, because it is not implemented in the code.

I implemented group delay (GD) in this changeset: https://github.com/ttrftech/NanoVNA/pull/48/commits/e81f4fe82872c434b58e2cb87263d79a07322156

Also it will be nice to add phase delay (PD) trace. But it requires continuous phase unwrap for entire sweep, so I'm not sure how to implement it with no use additional memory.

edy555 commented 5 years ago

Thanks for creating separate PRs.

Currently, format group delay is implemented in branch https://github.com/ttrftech/NanoVNA/commits/format_delay and it will be merged. But seeing your implementation I feel interesting and helpful. Thank you!

qrp73 commented 5 years ago

Thanks, also it will be nice to add phase delay (PD) trace