search

ttrftech / NanoVNA

Very Tiny Palmtop Vector Network Analyzer
1.06k stars 297 forks source link

Smith value format is not persistent #99

Closed owenduffy closed 4 years ago

owenduffy commented 4 years ago

It appears that selecting Smith value format R+jX does not persist over power off.

The text also collides with the entry to the right.

Screenshot-191211061717

edy555 commented 4 years ago

Yes, currently smith value format is not stored but will be supported in near releases.

owenduffy commented 4 years ago

It could be argued that the default format should be R+jX.

Further, that your Ω symbol should be on the right hand end of the whole complex value, there should be no space between real and imaginary parts (with a + sign to separate as needed), and the J should be j (J is for joules) and be between the imaginary parts sign and its numeric characters.

Screen space is very valuable, so why not abbreviate SMITH to SM? If there is no facility to scale the Smith chart display, what is the value of the "1.0FS" display?

Adding this feature is a significant improvement on the hammy presentation, fixing these issues is as big an improvement.

Thanks for the good work.

Owen

jp3141 commented 4 years ago

so the format should look like: 49.2-j2.87m Ω // only space is between the last character of the value and the Ω symbol

owenduffy commented 4 years ago

Quite, but screen space is a premium so I have no problems with no space between value and unit (as is done with other quantities).

edy555 commented 4 years ago

Smith value format became persistent in 0.6.0 release https://github.com/ttrftech/NanoVNA/releases/tag/0.6.0